Skip to content

Replace delegate based server impl with call handler #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marcoferrer wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Replace delegate based server impl with call handler #102

marcoferrer wants to merge 20 commits into from

Conversation

@marcoferrer
Copy link
Owner

@marcoferrer marcoferrer commented Dec 31, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 31, 2019 •
edited
Loading

Codecov Report

Merging #102 into master will decrease coverage by 22.5%.
The diff coverage is 89.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #102       +/-   ##
=============================================
- Coverage      87.8%   65.29%   -22.51%     
- Complexity       21       22        +1     
=============================================
  Files            16       19        +3     
  Lines           369      608      +239     
  Branches         50       75       +25     
=============================================
+ Hits            324      397       +73     
- Misses           26      183      +157     
- Partials         19       28        +9
Impacted Files Coverage Δ Complexity Δ
...us/coroutines/client/ClientStreamingCallChannel.kt 100% <ø> (+18.18%) 0 <0> (ø) ⬇️
...oferrer/krotoplus/coroutines/server/ServerCalls.kt 5.81% <ø> (-82.56%) 0 <0> (ø)
.../marcoferrer/krotoplus/coroutines/call/CallExts.kt 89.74% <100%> (+4.89%) 0 <0> (ø) ⬇️
...s/coroutines/server/DeferredCancellationHandler.kt 78.57% <78.57%> (ø) 5 <5> (?)
...oplus/coroutines/client/ClientResponseObservers.kt 80.55% <80.55%> (ø) 0 <0> (?)
...rer/krotoplus/coroutines/call/CallReadyObserver.kt 93.33% <93.33%> (ø) 7 <7> (?)
.../krotoplus/coroutines/server/ServerCallHandlers.kt 95.08% <95.08%> (ø) 0 <0> (?)
...oferrer/krotoplus/coroutines/client/ClientCalls.kt 89.85% <95.12%> (-1.06%) 0 <0> (ø)
...otoplus/coroutines/client/ClientBidiCallChannel.kt 6.66% <0%> (-90%) 0% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad7b71...b232741. Read the comment docs.

@marcoferrer marcoferrer force-pushed the server-call-handler-impl branch from 51f2db5 to 9bd2cde Compare January 12, 2020 17:21
@marcoferrer marcoferrer force-pushed the server-call-handler-impl branch from 9bd2cde to 27e77d7 Compare January 12, 2020 17:47
@marcoferrer marcoferrer force-pushed the server-call-handler-impl branch from 30eb80f to 7e3ae1f Compare January 13, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcoferrer